Make Path::push match std more closely#131
Open
sosthene-nitrokey wants to merge 1 commit into
Open
Conversation
| @@ -1,4 +1,4 @@ | |||
| #![no_std] | |||
| #![cfg_attr(not(test), no_std)] | |||
Member
There was a problem hiding this comment.
I’d prefer
#![no_std]
# [cfg(test)]
extern crate std;for a consistent prelude.
sosthene-nitrokey
force-pushed
the
path-push-match-std
branch
2 times, most recently
from
28b3360 to
fd591c9
Compare
std's PathBuf clears the pathbuf whenever the pushed path is absolute, not just when it's "/"
sosthene-nitrokey
force-pushed
the
path-push-match-std
branch
from
fd591c9 to
1035f50
Compare
Member
|
Do you think we should merge this now and make the next release a minor release or should we keep it open until we have to make a breaking release anyway? If we merge it now we cannot easily do a v0.1.3 release if we need to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std's PathBuf clears the pathbuf whenever the pushed path is absolute, not just when it's "/"