feature android (termux)#1066
Open
franklaranja wants to merge 1 commit into
Open
Conversation
With the feature `termux` enabled trunk can be build on termux (android). As tools are not released as binaries for android, trunk will install tools using pkg (wasm-opt), cargo install (wasm-bindgen-cli) or npm (sass & tailwind). The release.yaml has been updated to include android-termux binaries. Added android-termux releases to release.yaml Test release.yaml version bugfix release.yaml bugfix release.yaml bugfix release.yaml added android targets to Cross.toml removed testing config from release.yaml
Collaborator
|
Sorry for the late response on this one. It feels rather invasive, and I'm not sure many people will benefit from it. Might also be hard to test. I wonder if we could split this up somehow into smaller bits. |
Author
|
Hi Jens,
I conclude you don't want to include my changes, so maybe it is better i maintain the fork and publish it to crates.io.
Cheers,
Frank
…On June 8, 2026 9:08:10 AM GMT+01:00, Jens Reimann ***@***.***> wrote:
ctron left a comment (trunk-rs/trunk#1066)
Sorry for the late response on this one. It feels rather invasive, and I'm not sure many people will benefit from it. Might also be hard to test.
I wonder if we could split this up somehow into smaller bits.
--
Reply to this email directly or view it on GitHub:
#1066 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Collaborator
|
That's not what I was trying to say. However, there are multiple aspects in this PR. Some of them touch a lot of code. I'd prefer splitting things up. The current things I see are (maybe I missed some):
But there are a lot of cases where "if not android" was added, and it's not really structured. We have a similar case (conditionally compiled) with the version check: https://github.com/trunk-rs/trunk/tree/main/src/version … I think it's more structured, and isolated the specific parts. I'd prefer to see that here too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the feature
termuxenabled trunk can be build on termux (android). As tools are not released as binaries for android, trunk will install tools using pkg (wasm-opt), cargo install (wasm-bindgen-cli) or npm (sass & tailwind).The release.yaml has been updated to include android-termux binaries.