Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test all option #20

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add test all option #20

wants to merge 2 commits into from

Conversation

pat-trunk-io
Copy link
Contributor

@pat-trunk-io pat-trunk-io commented Apr 19, 2024 •
edited
Loading

Add an option to test all instead of calling bazel-diff

TylerJang27
TylerJang27 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for short term, may also want to add a comment noting that force-all-tests is experimental for anyone else using this

We'll add something more sustainable long-term

@TylerJang27 TylerJang27 mentioned this pull request Jun 26, 2024
Draft
@TylerJang27 TylerJang27 marked this pull request as draft June 26, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pat-trunk-io @TylerJang27