Skip to content

Remove uuidv5 generation for xcresult #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnalh
Copy link
Collaborator

@gnalh gnalh commented Jan 16, 2025

This has been moved into the ETL. Both forms will be supported until we EOL 0.6.11. Confirmed that uploads are still mapping to the same tests.

Example:
Latest CLI and local CLI with this change
Screenshot 2025-01-21 at 9 40 25 AM

Only one test exists in new repo.
Screenshot 2025-01-21 at 9 40 39 AM

2 test runs matching the uploads
Screenshot 2025-01-21 at 9 40 48 AM
Screenshot 2025-01-21 at 9 40 44 AM

Copy link

trunk-io bot commented Jan 16, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link

trunk-staging-io bot commented Jan 16, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@gnalh gnalh force-pushed the gabe/stop-generating-uuidv5 branch 3 times, most recently from 34a6f4d to 16fa48f Compare January 21, 2025 17:20
@gnalh gnalh marked this pull request as ready for review January 21, 2025 17:42
@gnalh gnalh force-pushed the gabe/stop-generating-uuidv5 branch from 16fa48f to 2fae3c7 Compare January 29, 2025 17:42
@gnalh
Copy link
Collaborator Author

gnalh commented Jan 29, 2025

Moving this back into review, looks like it breaks the quarantining logic when calling the api.

@gnalh gnalh marked this pull request as draft January 29, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants