feat: describe taxonomy #842
Merged
+91
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicBun
force-pushed
the
feat/describeTaxonomy
branch
from
8ce3c08 to
119e728
Compare
MicBun
force-pushed
the
feat/describeTaxonomy
branch
from
119e728 to
d306725
Compare
outerlook
approved these changes
Mar 11, 2025
|
@outerlook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed after: #841
Description
This pull request introduces significant changes to the taxonomy management system and enhances the query testing framework. The key updates include modifications to the database schema, new actions for handling taxonomies, and additional test setups for composed streams.
Database Schema and Actions:
internal/migrations/000-initial-data.sql: Reordered thechild_stream_idandchild_data_providerfields in thetaxonomiestable to maintain consistency.internal/migrations/004-composed-taxonomy.sql: Added new actions for inserting taxonomies, retrieving the current version, and describing taxonomies. These actions include validations and ensure that all child arrays have the same length before insertion.Testing Enhancements:
tests/streams/query/query_test.go: Introduced new constants and a helper functionWithComposedQueryTestSetupto set up the test environment for composed streams. Added a new testtestAGGR03_ComposedStreamWithWeightsto validate the taxonomy definition and its period of validity. [1] [2] [3] [4]Utility Functions:
tests/streams/utils/setup/composed.go: Updated the setup functions to handle composed streams more effectively. This includes setting the taxonomy after deploying primitive streams and parsing weights as decimals. [1] [2] [3] [4] [5] [6]Related Problem
resolves: #839
How Has This Been Tested?
Run test for WithComposedQueryTestSetup(testAGGR03_ComposedStreamWithWeights(t))