Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't read records #145

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix: can't read records #145

merged 1 commit into from
Mar 4, 2025

Conversation

MicBun
Copy link
Contributor

@MicBun MicBun commented Mar 4, 2025

resolves: #144

This pull request introduces a significant update to the task_read_records function in the src/tsn_adapters/blocks/tn_access.py file. The update aims to enhance the function's flexibility and robustness by allowing it to handle both ISO dates and Unix timestamps.

Enhancements to task_read_records function:

  • Added support for both ISO dates and Unix timestamps by introducing the is_unix parameter, which determines the date format to be used.
  • Updated the function signature to include a retry mechanism with specified retry conditions and delay.
  • Included detailed docstrings to improve code documentation and clarity, outlining the function's arguments and return value.
  • Implemented conditional logic to handle the conversion and processing of dates based on the is_unix parameter.

@MicBun MicBun requested a review from outerlook March 4, 2025 15:04
@MicBun MicBun self-assigned this Mar 4, 2025
@MicBun
Copy link
Contributor Author

MicBun commented Mar 4, 2025

@pr-time-tracker bug commit 13399e8 && bug author @outerlook

Copy link

pr-time-tracker bot commented Mar 4, 2025

@outerlook
⚠️⚠️⚠️
You must submit the time spent on this PR.
⚠️⚠️⚠️

@MicBun MicBun merged commit 2c0716c into main Mar 4, 2025
2 of 3 checks passed
@MicBun MicBun deleted the fix/readRecord branch March 4, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: can't read records
2 participants