This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat: accept cli args over env vars #810
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
force-pushed
the
develop
branch
3 times, most recently
from
96d6c7f to
47d583d
Compare
davidmurdoch
force-pushed
the
develop
branch
5 times, most recently
from
892c68f to
0e9642f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now do
$ GANACHE_wallet__totalAccounts=5 ganacheinstead of$ ganache --wallet.totalAccounts 5-- a feature which was previously requested here.I've found it is a nice feature to have when CLI tool is used in an npm package script, as I don't need to configure the script to accept the params (via
command -- args).Options are applied in the following order: ENV vars, config file, cli options. We don't yet support config-file parsing, but I'll add it in a future PR.