[URI] Do not attempt multiple verification attempts if host is non-resolvable #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
force-pushed
the
feat/uri-ignore-invalid
branch
2 times, most recently
from
a9b65f5 to
9c2590c
Compare
rgmz
commented
Nov 21, 2024
Comment on lines
+37
to
+38
|
|
||
| hostNotFoundCache = simple.NewCache[struct{}]() |
There was a problem hiding this comment.
I think this would benefit from being centralized and shared by all detectors. A domain that's found to not exist for Azure Container Registry, Azure OpenAI, JDBC (below), etc. is applicable to any other detector.
Found unverified result 🐷🔑❓
Verification issue: lookup your_server.database.windows.net: no such host
Detector Type: JDBC
Decoder Type: PLAIN
Raw result: jdbc:sqlserver://your_server.database.windows.net:1433;
Commit: aa081336863641da6061a892c7304f9823b4e8d6
Commit_source: refs/remotes/origin/pull/2/head (hidden ref)
Email: Brian Gianforcaro <[email protected]>
File: Java/sample_java.java
Line: 11
Link: https://github.com/Azure/azure-sql-database-samples/blob/aa081336863641da6061a892c7304f9823b4e8d6/Java/sample_java.java#L11
Repository: https://github.com/Azure/azure-sql-database-samples.git
Timestamp: 2015-09-28 17:26:38 +0000
| ) | ||
|
|
||
| // Keywords are used for efficiently pre-filtering chunks. | ||
| // Use identifiers in the secret preferably, or the provider name. | ||
| func (s Scanner) Keywords() []string { | ||
| return []string{"http"} | ||
| return []string{"http://", "https://"} |
There was a problem hiding this comment.
As far as I can tell, http:// and https:// are more correct and efficient keywords.
kashifkhan0771
requested changes
Nov 22, 2024
| var _ detectors.CustomFalsePositiveChecker = (*Scanner)(nil) | ||
| var _ interface { | ||
| detectors.Detector | ||
| detectors.CustomFalsePositiveChecker |
There was a problem hiding this comment.
Is there any reason why we ignore all false positives for this detector with custom logic?
There was a problem hiding this comment.
I suspect there were too many results being filtered by the wordlist, so someone decided to do this workaround instead of removing the problematic entries.
See #3246
kashifkhan0771
approved these changes
Nov 25, 2024
rgmz
force-pushed
the
feat/uri-ignore-invalid
branch
2 times, most recently
from
ecc2700 to
4a0f5c2
Compare
rgmz
force-pushed
the
feat/uri-ignore-invalid
branch
from
4a0f5c2 to
ce72986
Compare
rgmz
force-pushed
the
feat/uri-ignore-invalid
branch
from
ce72986 to
57620fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The URI detector currently makes an indiscriminate number of HTTP requests to domains, regardless of whether they actually exist. This results in wasted network bandwidth and logs spammed with things like below.
In addition to de-duplicating matches, this updates the URI detector to track hosts that are not found and skip verification.
Checklist:
make test-community)?make lintthis requires golangci-lint)?