NAS-129920 / 24.10 / jsonrpc client #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
reviewed
Jul 5, 2024
| import enum | ||
|
|
||
|
|
||
| class JSONRPCError(enum.Enum): |
There was a problem hiding this comment.
Can we document where these are from?
There was a problem hiding this comment.
Can simply be link to protocol specifications.
anodos325
reviewed
Jul 5, 2024
creatorcary
reviewed
Jul 24, 2024
creatorcary
reviewed
Jul 31, 2024
yocalebo
approved these changes
Aug 15, 2024
aiden3c
approved these changes
Aug 15, 2024
creatorcary
approved these changes
Aug 15, 2024
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-129920 is targeted to the following versions which have not received their corresponding PRs: 24.10-RC.1, 25.04 |
|
This PR has been merged and conversations have been locked. |
|
time 20:00 |
|
Time tracking added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.