Warn when -j used unnecessarily #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themylogin
requested changes
Mar 3, 2025
| if job == 'RETURN': | ||
| return jobobj | ||
| return jobobj.result() | ||
| if c.result in self._jobs: |
There was a problem hiding this comment.
This might be a race condition. How can we know that we've already received and handled a core.get_jobs ADDED event by the time we receive method return value?
There was a problem hiding this comment.
Should we raise an exception in Job.__init__ instead?
There was a problem hiding this comment.
How will this change anything?
There was a problem hiding this comment.
With current architecture, there is no way to synchronize these events.
We also plan to get rid of jobs in 25.10
There was a problem hiding this comment.
Feel free to close this PR if you determine that it wouldn't be helpful.
|
Closing this as it is difficult to implement properly, and we're dropping jobs in 25.10 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the user mistakenly passes the
-jflag to call a job when the method does not represent a job. We should handle this cleanly by recognizing the result is not a job ID and handling the call as if-jhad not been passed while warning the user.