chore: use typescript-eslint@v6 with reworked configs (#4541)

* feat: use typescript-eslint@v6 with reworked configs * Fix formatting * Fix config?.reactQueryContext * activate some stuff * prefer nullish * huh * prettier * fix --------- Co-authored-by: juliusmarminge <[email protected]>
trpc · Jun 28, 2023 · e7edc53 · e7edc53
1 parent 7b06f63
commit e7edc53
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 12 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -1,7 +1,8 @@
 {
   "parser": "@typescript-eslint/parser", // Specifies the ESLint parser
   "extends": [
-    "plugin:@typescript-eslint/recommended", // Uses the recommended rules from the @typescript-eslint/eslint-plugin
+    "plugin:@typescript-eslint/recommended-type-checked",
+    "plugin:@typescript-eslint/stylistic-type-checked",
     "plugin:react/recommended",
     "plugin:react-hooks/recommended",
     "plugin:prettier/recommended"
@@ -13,11 +14,24 @@
   },
   "rules": {
     // Place to specify ESLint rules. Can be used to overwrite rules specified from the extended configs
-    "@typescript-eslint/explicit-function-return-type": "off",
-    "@typescript-eslint/explicit-module-boundary-types": "off",
+    "@typescript-eslint/consistent-type-definitions": "off",
     "react/react-in-jsx-scope": "off",
     "react/prop-types": "off",
-    "@typescript-eslint/no-explicit-any": "off"
+
+    // Consider removing these rule disables for more type safety in your app ✨
+    "@typescript-eslint/no-confusing-void-expression": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-floating-promises": "off",
+    "@typescript-eslint/no-misused-promises": "off",
+    "@typescript-eslint/no-unsafe-assignment": "off",
+    "@typescript-eslint/no-unsafe-argument": "off",
+    "@typescript-eslint/no-unsafe-call": "off",
+    "@typescript-eslint/no-unsafe-declaration-merging": "off",
+    "@typescript-eslint/no-unsafe-return": "off",
+    "@typescript-eslint/no-unsafe-member-access": "off",
+    "@typescript-eslint/prefer-nullish-coalescing": "off",
+    "@typescript-eslint/require-await": "off",
+    "@typescript-eslint/restrict-plus-operands": "off"
   },
   // "overrides": [
   //   {

diff --git a/package.json b/package.json
@@ -62,8 +62,8 @@
     "@types/node": "^18.16.16",
     "@types/react": "^18.2.8",
     "@types/ws": "^8.2.0",
-    "@typescript-eslint/eslint-plugin": "^5.59.2",
-    "@typescript-eslint/parser": "^5.59.2",
+    "@typescript-eslint/eslint-plugin": "6.0.0-alpha.158",
+    "@typescript-eslint/parser": "6.0.0-alpha.158",
     "autoprefixer": "^10.4.7",
     "cross-env": "^7.0.3",
     "eslint": "^8.40.0",

diff --git a/src/server/context.ts b/src/server/context.ts
@@ -11,8 +11,8 @@ import ws from 'ws';
  */
 export const createContext = async (
   opts:
-    | trpcNext.CreateNextContextOptions
-    | NodeHTTPCreateContextFnOptions<IncomingMessage, ws>,
+    | NodeHTTPCreateContextFnOptions<IncomingMessage, ws>
+    | trpcNext.CreateNextContextOptions,
 ) => {
   const session = await getSession(opts);
 

diff --git a/src/server/prodServer.ts b/src/server/prodServer.ts
@@ -35,7 +35,6 @@ void app.prepare().then(() => {
   });
   server.listen(port);
 
-  // tslint:disable-next-line:no-console
   console.log(
     `> Server listening at http://localhost:${port} as ${
       dev ? 'development' : process.env.NODE_ENV

diff --git a/src/server/routers/post.ts b/src/server/routers/post.ts
@@ -46,7 +46,9 @@ const interval = setInterval(() => {
     ee.emit('isTypingUpdate');
   }
 }, 3e3);
-process.on('SIGTERM', () => clearInterval(interval));
+process.on('SIGTERM', () => {
+  clearInterval(interval);
+});
 
 export const postRouter = router({
   add: authedProcedure
@@ -105,7 +107,7 @@ export const postRouter = router({
         skip: 0,
       });
       const items = page.reverse();
-      let prevCursor: null | typeof cursor = null;
+      let prevCursor: typeof cursor | null = null;
       if (items.length > take) {
         const prev = items.shift();
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
@@ -119,7 +121,9 @@ export const postRouter = router({
 
   onAdd: publicProcedure.subscription(() => {
     return observable<Post>((emit) => {
-      const onAdd = (data: Post) => emit.next(data);
+      const onAdd = (data: Post) => {
+        emit.next(data);
+      };
       ee.on('add', onAdd);
       return () => {
         ee.off('add', onAdd);