feat(LiteFullNode): remove LiteFullNodeTool #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add ClearABIServletTest 2. add CreateAccountServletTest 3. CreateAssetIssueServletTest
Gemk83
approved these changes
Jan 10, 2024
lurais
reviewed
Jan 16, 2024
| @@ -239,13 +239,11 @@ createScript(project, 'org.tron.program.SolidityNode', 'SolidityNode') | |||
| createScript(project, 'org.tron.program.FullNode', 'FullNode') | |||
| createScript(project, 'org.tron.program.KeystoreFactory', 'KeystoreFactory') | |||
| createScript(project, 'org.tron.program.DBConvert', 'DBConvert') | |||
| createScript(project, 'org.tron.tool.litefullnode.LiteFullNodeTool', 'LiteFullNodeTool') | |||
There was a problem hiding this comment.
Some comments should be updated such as this :
| @@ -66,7 +66,6 @@ DB copy provides a helper which can copy LevelDB or RocksDB data quickly on the | |||
| java -jar Toolkit.jar db cp output-directory/database /tmp/databse | |||
| ``` | |||
|
|
|||
|
|
|||
| ## DB Lite | |||
|
|
|||
| DB lite provides lite database, parameters are compatible with previous `LiteFullNodeTool`. | |||
There was a problem hiding this comment.
LiteFullNodeTool has been removed ,is it reasonable to quote something not existed?
There was a problem hiding this comment.
This description is an indication to reference the previous LiteFullNodeTool instead of using the LiteFullNodeTool
halibobo1205
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1.Remove
LiteFullNodeToolCode.2.add test case
Why are these changes required?
LiteFullNodeToolfunctionality has been replaced byToolkit.jar.This PR has been tested by:
Follow up
Extra details