Switch from PF_INET to AF_PACKET #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* otherwise Ski crashes on first console input (w/PF_INET) or * the selected interface cannot be used inside Ski (w/AF_PACKET).
trofi
approved these changes
Feb 12, 2025
|
Looks great! Merged as is. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set switches the "networking" functionality of Ski from using
PF_INETto usingAF_PACKETinstead. Running a Ski instance with this patch set applied will no longer cause the host kernel to printbski uses obsolete (PF_INET,SOCK_PACKET)to the system console.The change also solves the issue that came with the use of the
sockaddr.sa_dataarray for "storing" the interface's name which can be up to 16 characters long (incl. binary zero) butsa_datahas only room for 14 characters and is also not meant for storage according to bind(2). E.g. before this change I had to shorten the long interface name of my USB2Ethernet adapter (which included its MAC address) toeth4000000013to make it usable for Ski.I didn't observe any regressions when comparing operation of Ski at 71cdaba compared to Ski with this patch set applied and testing network related stuff (like using
telnetorncto execute commands in Ski, or mounting an NFS share and write/read/copy files there).In addition this patch set also includes:
ifenslave) to bring up the selected network interface on the host for use by Ski before using it in Ski. During testing, this was a required prerequisite for successful operation (both forPF_INETandAF_PACKETcases, see commit message for respective behavior w/o doing this).