Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex shapes docs #587

Merged
merged 154 commits into from
Aug 12, 2024
Merged

Complex shapes docs #587

merged 154 commits into from
Aug 12, 2024

Conversation

LasNikas
Copy link
Collaborator

@LasNikas LasNikas commented Aug 1, 2024

No description provided.

@LasNikas LasNikas marked this pull request as ready for review August 6, 2024 08:41
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
svchb
svchb previously approved these changes Aug 7, 2024
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice explanation! Sorry for the large number of comments.

Also, can you please replace all $ by double backticks, as the former are deprecated?

docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the open conversation above is missing.

docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
docs/src/preprocessing/preprocessing.md Outdated Show resolved Hide resolved
@svchb svchb enabled auto-merge (squash) August 12, 2024 09:52
@svchb svchb merged commit c565f67 into trixi-framework:main Aug 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants