-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D Cartesian Shallow Water Equations #36
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 82.31% 84.71% +2.39%
==========================================
Files 8 11 +3
Lines 854 1125 +271
==========================================
+ Hits 703 953 +250
- Misses 151 172 +21 ☔ View full report in Codecov by Sentry. |
… the curl invariant form (we need the surface Jacobian, not the volume Jacobian...)
…ve for Cartesian solvers (not used)
examples/elixir_shallowwater_cubed_sphere_shell_EC_correction.jl
Outdated
Show resolved
Hide resolved
…and docstrings/comments
…proved the description
…xirs and added instead a specialized rhs! function for 2D manifolds embedded in 3D
examples/elixir_shallowwater_cubed_sphere_shell_EC_correction.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds the 3D Shallow Water Equations (SWE) in Cartesian form, which can be solved on a 2D manifold embedded in 3D. We add two strategies to obtain entropy (total energy) conservation based on two-point fluxes: (i) using an entropy correction term, and (ii) using an entropy-consistent projection of the momentum. Both strategies require divergence-free metric terms on the 2D manifold. In this PR, we implement the curl-invariant form of Kopriva (2006). We also add the possibility to discretize the equations with the weak-form kernel.