Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D Cartesian Shallow Water Equations #36

Merged
merged 20 commits into from
Nov 8, 2024

Conversation

amrueda
Copy link
Collaborator

@amrueda amrueda commented Sep 16, 2024

This PR adds the 3D Shallow Water Equations (SWE) in Cartesian form, which can be solved on a 2D manifold embedded in 3D. We add two strategies to obtain entropy (total energy) conservation based on two-point fluxes: (i) using an entropy correction term, and (ii) using an entropy-consistent projection of the momentum. Both strategies require divergence-free metric terms on the 2D manifold. In this PR, we implement the curl-invariant form of Kopriva (2006). We also add the possibility to discretize the equations with the weak-form kernel.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.71%. Comparing base (30bdb23) to head (7a42b0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/equations/shallow_water_3d.jl 88.31% 18 Missing ⚠️
...vers/dgsem_p4est/dg_2d_manifold_in_3d_cartesian.jl 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   82.31%   84.71%   +2.39%     
==========================================
  Files           8       11       +3     
  Lines         854     1125     +271     
==========================================
+ Hits          703      953     +250     
- Misses        151      172      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amrueda amrueda changed the title WIP: Add ES discretization for Cartesian Shallow Water Equations Add Cartesian Shallow Water Equations Sep 17, 2024
@amrueda amrueda changed the title Add Cartesian Shallow Water Equations Add 3D Cartesian Shallow Water Equations Sep 17, 2024
@amrueda amrueda marked this pull request as ready for review September 17, 2024 16:28
src/TrixiAtmo.jl Outdated Show resolved Hide resolved
tristanmontoya
tristanmontoya previously approved these changes Nov 8, 2024
Copy link
Member

@tristanmontoya tristanmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tristanmontoya tristanmontoya merged commit 49ec206 into main Nov 8, 2024
10 checks passed
@tristanmontoya tristanmontoya deleted the arr/spherical_shallow_water_es branch November 8, 2024 16:26
tristanmontoya added a commit that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants