Merging thesis_gemein_2022 into TrixiAtmo.jl

[Arpit-Babbar]

This PR started as an explanation to #1. Now, it adds all the elixirs with respective CI tests from Lucas' thesis.

TODO

• Add tests for elixirs
• Resolve repetition from Trixi in the process of adding tests. That is, this file https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/test/test_trixiatmo.jl is copied from Trixi.jl.
• Are the 1920 allocations expected? (They didn't show up in CI, so we are good)
• Add tests for the remaining 5/7 elixirs

[tristanmontoya]

This is a good start for TrixiAtmo.jl, and should be quite useful. I will have some time to look into the specifics more in the next week, but my first thought is that we should perhaps set up testing/CI (similarly to TrixiShallowWater.jl) before merging this to main.

[github-actions]

Pull Request Test Coverage Report for Build 9959365955

Details

• 0 of 567 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-99.3%) to 0.701%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/equations/compressible_moist_euler_2d.jl	0	567	0.0%

Totals
Change from base Build 9959098082:	-99.3%
Covered Lines:	4
Relevant Lines:	571

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9970231868

Details

• 211 of 568 (37.15%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-62.4%) to 37.587%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/equations/compressible_moist_euler_2d.jl	211	568	37.15%

Totals
Change from base Build 9959098082:	-62.4%
Covered Lines:	215
Relevant Lines:	572

---

💛 - Coveralls

[Arpit-Babbar]

Minor fixes

[codecov]

Codecov Report

Attention: Patch coverage is 73.76761% with 149 lines in your changes missing coverage. Please review.

Project coverage is 50.90%. Comparing base (1c7efd9) to head (5f91de5).
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/equations/compressible_moist_euler_2d_lucas.jl	73.76%	149 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   19.34%   50.90%   +31.55%     
===========================================
  Files           8        8               
  Lines         827      827               
===========================================
+ Hits          160      421      +261     
+ Misses        667      406      -261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benegee]

• Resolve repetition from Trixi in the process of adding tests. That is, this file https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/test/test_trixiatmo.jl is copied from Trixi.jl.

At first I though that we could maybe move some parts to TrixiBase.jl, but then I realized that these macro e.g. explicitly include the Trixi. Maybe we should therefore just add our own macros as need be.

[benegee]

• Are the 1920 allocations expected?

Which test case was it?

[tristanmontoya]

It looks good to me, although I am wondering if either of you (@Arpit-Babbar or @benegee) know the reason for the warnings copied below? My tests have always been very simple so I've never run into this.

WARNING: replacing module TrixiAtmoTestModule.
WARNING: could not import TestExamples2DMoistEuler.TRIXI_EXAMPLES_DIR into TrixiAtmoTestModule

[tristanmontoya]

I think it's good to merge if we're ok with the warnings I mentioned above.

[ranocha]

It looks good to me, although I am wondering if either of you (@Arpit-Babbar or @benegee) know the reason for the warnings copied below? My tests have always been very simple so I've never run into this.

WARNING: replacing module TrixiAtmoTestModule. WARNING: could not import TestExamples2DMoistEuler.TRIXI_EXAMPLES_DIR into TrixiAtmoTestModule

You define a module with the same name every time in

TrixiAtmo.jl/test/test_trixiatmo.jl

Line 28 in 1c7efd9

@eval module TrixiAtmoTestModule

If you want to get rid of that warning, you could gensym an appropriate name - but I don't think that's necessary right now.