Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new MPI custom ops in mpi reduce #2066

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Use new MPI custom ops in mpi reduce #2066

wants to merge 22 commits into from

Commits on Aug 30, 2024

  1. use Base.min/max in MPI.Allreduce 

    MPI.jl's reduce currently does not work for custom operators (such as Trixi's
min/max) on ARM
    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4a137bd View commit details
    Browse the repository at this point in the history

  2. add comments

    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ed2540d View commit details
    Browse the repository at this point in the history

  3. explain workdaround

    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    cc1147d View commit details
    Browse the repository at this point in the history

  4. typo

    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fb8a769 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Hendrik Ranocha <[email protected]>
    @benegee @ranocha
    benegee and ranocha committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7cd8456 View commit details
    Browse the repository at this point in the history

  6. switch to macos-latest in mpi tests

    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    246f3ac View commit details
    Browse the repository at this point in the history

  7. remove arch specification for macos-latest 

    macos-latest is 14, which is ARM
    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    1d6e7f9 View commit details
    Browse the repository at this point in the history

  8. readd arch, required by julia-actions/setup-julia

    @benegee
    benegee committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    db209ec View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'main' into bg/base_min_in_mpi_reduce

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e6152c7 View commit details
    Browse the repository at this point in the history

  2. check out Valentin's MPI custom ops

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    940ee69 View commit details
    Browse the repository at this point in the history

  3. pkg command

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e46deeb View commit details
    Browse the repository at this point in the history

  4. hmpf

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    035b35d View commit details
    Browse the repository at this point in the history

  5. project path

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7154dae View commit details
    Browse the repository at this point in the history

  6. format

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ff513ba View commit details
    Browse the repository at this point in the history

  7. back to macos-13 and x64

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6c659f5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'bg/base_min_in_mpi_reduce' into bg/custom_ops_macro_in_… 

    …mpi_reduce
    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2ca05fe View commit details
    Browse the repository at this point in the history

  9. move to aarch64 for macos

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    10b0c3d View commit details
    Browse the repository at this point in the history

  10. can now use Any

    @benegee
    benegee committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    aeb0b3e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. move install of MPI branch

    @vchuravy
    vchuravy committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0bcf9e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. use custom op in 3D as well

    @benegee
    benegee committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    96d831e View commit details
    Browse the repository at this point in the history

  2. do not include latest commit

    @benegee
    benegee committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7330845 View commit details
    Browse the repository at this point in the history

  3. format

    @benegee
    benegee committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5d6a59a View commit details
    Browse the repository at this point in the history