Replace mutable structs using Adapt

[huiyuxie]

Mutable structs cannot be compiled to bits type on GPU. Using Adapt to translate the mutable structs to an immutable struct can be a good way to address this.

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[huiyuxie]

Looks like it is still causing a bunch of errors😢

[vchuravy]

An alternative would be to use Adapt to translate the mutable structs to an immutable struct that works on the GPU.
Might require introducing a new abstract type in the type hierarchy so that the dispatch still works out.

[huiyuxie]

Thanks @vchuravy let me have a try :)

[huiyuxie]

Not sure whether doing this on my repo or here would be better - let me try both ways and compare.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (f9c9107) to head (7594e4e).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2050   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         470      470           
  Lines       37447    37447           
=======================================
  Hits        36070    36070           
  Misses       1377     1377           

Flag	Coverage Δ
unittests	96.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ranocha]

Not sure whether doing this on my repo or here would be better - let me try both ways and compare.

You can also continue with your previous approach and make the semidiscretization mutable. Maybe it's worth comparing all three approaches to see what works best in terms of code complexity and performance.

[huiyuxie]

@ranocha Sure

[huiyuxie]

Temporary fix by #2052 - we will see whether that solution can be permanent.