forked from rockcarver/frodo-lib
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Journey Metadata with ability to exclude coordinates or update coordinates based on existing Journeys. #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to stripping coordinates we probably need to think of a way to separate and preserve coordinates from the journey files. From the developer perspective the x/y coordinates are useful since sometimes the auto-layout just doesn't cut it, but we probably want to ignore coordinate changes from the customer environment. |
brain-hol
approved these changes
Sep 28, 2023
…r journey imports to pull coordinates from server if they exist. Add tests for these features.
phalestrivir
force-pushed
the
feature/improved-journey-metadata-FIXED
branch
from
October 31, 2023 19:57
9eb0053
to
a8ac091
Compare
…r journey imports to pull coordinates from server if they exist. Add tests for these features.
…a-FIXED' into feature/improved-journey-metadata-FIXED # Conflicts: # CHANGELOG.md # package.json
Merged into Rockcarver's version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch goes in hand with the feature/improved-journey-metadata in the frodo-cli