Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NVIDIA] Prefer nvvm intrinsics over custom PTX #5733

Merged

Conversation

peterbell10
Copy link
Contributor

@peterbell10 peterbell10 commented Jan 28, 2025

[NVIDIA] Prefer nvvm intrinsics over custom PTX

For the most part, I expect this will just be a minor cleanup. It is
vaguely possible that this might enable some better codegen.

PR chain

  1. 👉 [NVIDIA] Prefer nvvm intrinsics over custom PTX #5733 👈 YOU ARE HERE

Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbell10 peterbell10 force-pushed the pb/pr-chain/nvidia_prefer_nvvm_intrinsics_over_custo_fe5c branch from fe0f0c9 to 2f587b4 Compare January 28, 2025 21:52
Base automatically changed from pb/pr-chain/nvidia_use_native_bf16_ops_b2bb to main January 28, 2025 21:54
@peterbell10 peterbell10 force-pushed the pb/pr-chain/nvidia_prefer_nvvm_intrinsics_over_custo_fe5c branch from 2f587b4 to 75fcb1c Compare January 28, 2025 22:01
@peterbell10 peterbell10 enabled auto-merge (squash) January 28, 2025 22:10
@peterbell10 peterbell10 disabled auto-merge January 28, 2025 22:10
@peterbell10 peterbell10 enabled auto-merge (squash) January 28, 2025 22:10
@peterbell10 peterbell10 force-pushed the pb/pr-chain/nvidia_prefer_nvvm_intrinsics_over_custo_fe5c branch from 75fcb1c to 2bfabba Compare January 29, 2025 03:40
For the most part, I expect this will just be a minor cleanup. It is
vaguely possible that this might enable some better codegen.

git-pr-chain: nvidia_prefer_nvvm_intrinsics_over_custo_fe5c
@peterbell10 peterbell10 force-pushed the pb/pr-chain/nvidia_prefer_nvvm_intrinsics_over_custo_fe5c branch from 2bfabba to 4455940 Compare January 29, 2025 03:48
@peterbell10 peterbell10 merged commit 64fff02 into main Jan 29, 2025
7 checks passed
@peterbell10 peterbell10 deleted the pb/pr-chain/nvidia_prefer_nvvm_intrinsics_over_custo_fe5c branch January 29, 2025 04:04
peterbell10 added a commit that referenced this pull request Jan 29, 2025
Follow-up to #5733 which somehow the passed CI and auto-merged, even
with this bug. TMA should be using `bulk.commit.group` rather than
`commit.group`.
AlexAUT pushed a commit to AlexAUT/triton that referenced this pull request Jan 29, 2025
For the most part, I expect this will just be a minor cleanup. It is
vaguely possible that this might enable some better codegen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants