-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMD] AsyncCopyGlobalToLocal lowering to global.load.lds #5729
Draft
AlexAUT
wants to merge
19
commits into
triton-lang:main
Choose a base branch
from
AlexAUT:global_to_lds_lowering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+293
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAUT
force-pushed
the
global_to_lds_lowering
branch
from
January 29, 2025 09:51
9d346d0
to
893a254
Compare
zhanglx13
reviewed
Jan 30, 2025
supportedWidths.insert(16); | ||
supportedWidths.insert(32); | ||
if (targetInfo.getGPUKind() == llvm::AMDGPU::GPUKind::GK_GFX950) { | ||
supportedWidths.insert(98); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
96 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support lowering of
AsyncCopyGlobalToLocal
forgfx9
GPUs. The lowering does check if the resulting writes are coalesced which is a requirement by the hardware.Note that we are currently not emitting
AsyncCopyGlobalToLocal
for amd targets, this will come with a follow up PR.This PR is blocked by #5684