[AMD][BACKEND] Disable pingpong with non-local_load input. #5718
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pingpong pass only expects to handle local_load ops as A/B Avoid using the trasform when different op is detected.
zhanglx13
reviewed
Jan 28, 2025
antiagainst
requested changes
Jan 28, 2025
- improve code - add test
…o qfix-checklocal
antiagainst
requested changes
Jan 29, 2025
|
|
||
| #blocked = #ttg.blocked<{sizePerThread = [1, 8], threadsPerWarp = [8, 8], warpsPerCTA = [8, 1], order = [1, 0]}> | ||
| #blocked1 = #ttg.blocked<{sizePerThread = [8, 1], threadsPerWarp = [8, 8], warpsPerCTA = [1, 8], order = [0, 1]}> | ||
| #loc = loc("/home/jung/rocm/triton/python/perf-kernels/tools/tune_gemm/matmul_kernel.py":6:0) |
There was a problem hiding this comment.
Can you drop this #loc?
There was a problem hiding this comment.
Thanks for spotting this.
antiagainst
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pingpong pass only expects to handle local_load ops as A/B.
Avoid using the transform when different op is detected.
TODO: pingpong pass to be able to transform another types of ops as dot input.