[Triton] Add top-k operation to Triton language #5706
+102
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a top-k operator to the Triton language. This operator uses the sort function from triton.language to process an input tensor and a specified number of top elements, k. It returns a tuple containing the top-k elements and their corresponding original indices.
Jokeren
reviewed
Jan 27, 2025
Jokeren
reviewed
Jan 27, 2025
| :type k: int | ||
| :param descending: If True (default), returns the largest elements. If False, returns the smallest. | ||
| :type descending: bool | ||
| :return: A tuple of (top-k elements, top-k indices) tensors. |
There was a problem hiding this comment.
It's not true. What have been returned are still length n but not length k. It's not expected
Jokeren
reviewed
Jan 27, 2025
| @@ -1,4 +1,4 @@ | |||
| default_stages: [pre-commit, pre-push, manual] | |||
| default_stages: [pre-commit, commit-msg, manual, pre-merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg] | |||
There was a problem hiding this comment.
All those are unnecessary changes
There was a problem hiding this comment.
If needed, we should use a separate PR
|
A possible solution would be tl.sort + tl.gather (1...k) IMO |
+1, there are multiple way to implement topk and it is unlikely that this is the most efficient way. Maybe there is a place for this code in https://github.com/triton-lang/kernels as an example although the charter for this repo is still work in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a top-k operator to the Triton language. This operator uses the sort function from triton.language to process an input tensor and a specified number of top elements, k. It returns a tuple containing the top-k elements and their corresponding original indices.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)