[backend] NFC: Split architecture dependant and independant parts of FMA dot conversion #5655
+224
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits FMA dot conversion from Triton GPU to LLVM in two parts: - Common code with iteration across M/N dim - Architecture dependant scalar multiplication of vectos across K dim
antiagainst
requested changes
Jan 25, 2025
antiagainst
changed the title
- remove redundant namespaces - improve comments - use more general op builder class
antiagainst
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits FMA dot conversion from Triton GPU to LLVM in two parts:
This PR do not introduce any test, because it does not fix any bugs or introduce new functionality, it refactors code to simplify later changes: #4594