[Proton][Dialect] Add Proton Device Memory Buffer Init and Allocate Pass #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRobeck
changed the title
CRobeck
force-pushed
the
proton_buffer
branch
from
708cb2c to
73d584d
Compare
CRobeck
changed the title
CRobeck
changed the title
CRobeck
changed the title
fywkevin
requested changes
Jan 25, 2025
third_party/nvidia/lib/TritonNVIDIAGPUToLLVM/TritonGPUToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/proton/dialect/include/Dialect/Proton/IR/ProtonOps.td
Outdated
Show resolved
Hide resolved
third_party/proton/dialect/include/Dialect/Proton/IR/ProtonOps.td
Outdated
Show resolved
Hide resolved
| @@ -10,6 +10,11 @@ void populateRecordOpToLLVMPattern(LLVMTypeConverter &typeConverter, | |||
| RewritePatternSet &patterns, | |||
| const TargetInfoBase &targetInfo, | |||
| PatternBenefit benefit); | |||
| void populateInitDeviceBufferOpToLLVMPattern(LLVMTypeConverter &typeConverter, | |||
There was a problem hiding this comment.
After we have our own llvm lowering conversion pass, let's this move to proton/dialect/lib/...
third_party/proton/dialect/lib/TritonProtonToLLVM/InitDeviceBufferOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| @triton.jit | ||
| def softmax_kernel(output_ptr, input_ptr, input_row_stride, output_row_stride, n_rows, n_cols, BLOCK_SIZE: tl.constexpr, |
There was a problem hiding this comment.
For the end-to-end testing, you could manually construct a TTGIR with the buffer_alloc_op and read write to it and finally write it back to gmem to check its value in python.
There was a problem hiding this comment.
Right, I think we'll want to go through in another PR and add all the end to end testing at once to make sure we have the code coverage we want.
CRobeck
force-pushed
the
proton_buffer
branch
3 times, most recently
from
1c9d9ca to
7be389b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the init and allocation of the Proton dialect device buffer that can be used in place of the shared memory buffer. The device buffer is just a module local, zero initialized, stack buffer in address space(1).