fix(build): auto-run api-gen when generated files are missing#18
Open
neptunix wants to merge 1 commit into
Open
fix(build): auto-run api-gen when generated files are missing#18neptunix wants to merge 1 commit into
neptunix wants to merge 1 commit into
Conversation
`go build` fails after a plain `git clone` because the generated API files are gitignored. Add a guard to the `build` target that runs `make api-gen` automatically if the files are absent, so `git clone && make build` works out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
go buildfails after a plaingit clonebecause the generated API files (api/clickupv{2,3}/*.gen.go,internal/apiv{2,3}/operations.gen.go) are gitignored. This produces 14 compile errors for types that only exist in the generated code:Any Dockerfile or CI pipeline that does
git clone && go buildis broken.Fix
One line added to the
buildtarget — if the generated files are absent, runmake api-genfirst:Verification