New property giving map maker the ability to allow non-air SBU units to continue to the main territory battle. #12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkAIPlayers added to RulesAttachment to allow for checking of AI controlled players.
Rename from isAIPlayers to isAI
Spacing
Adding RulesAttachmentTest to test isAI
Removed extra line from each file
This property will map makers to select if non-air SBR units will be allow to patriciate in a territory's normal battle. This does not effect sea units as the "isStrategicBomber" option is still blocked for use. If this were unblocked then it would also effect them.
WCSumpton
changed the title
|
@WCSumpton Just skimmed over it, is there any test for the new property? If not, would be good to create some concerning the new property. |
|
I will try this property out in 1941 GCD with Artillery. It also has uses for siege warfare prior to WW2. |
For me, creating the test may take some time, will look into it. Was extensively tested using GCD v1.170, as the new update v1.175 removed the "isStrategicBomber" code for Artillery. Cheers... |
dependents seems to be reference farther on, so was replaced with attackingSBR. Also units were getting marked as being in air battles so this was changed to only include air units. Cheers...
hasResource will give mapmaker the ability to query resources
|
Closing due to conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a new map property "Use Non-Air SBR Units In Normal Battle" that when set to true will allow these units to participate in the normal territory battle.
Sea units are still blocked from using "isStrategicBomber", so this has no effect on them. If this were to change, then they would also be allowed to join.
Because this is a new property, there should be no effect to existing maps.
Cheers...