Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for setTableProperties in Faker connector #24598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sthandassery
Copy link

@sthandassery sthandassery commented Dec 31, 2024

Description

Adding test coverage for setTableProperties. As part of the unit test getTableComment utility is now moved down from BaseConnectorTest to AbstractTestQueryFramework class, so that TestFakerQueries can reuse it.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copy link

cla-bot bot commented Dec 31, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added iceberg Iceberg connector delta-lake Delta Lake connector labels Dec 31, 2024
Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and PR title are wrong

@ebyhr
Copy link
Member

ebyhr commented Dec 31, 2024

Fixes #23911

Please don't use "Fixes" comment. We should add more tests in #23911.

@sthandassery
Copy link
Author

The commit message and PR title are wrong

@nineinchnick Do you mean - moving the getTableComment utility needs to extracted out into its own commit?

@nineinchnick
Copy link
Member

This PR only moves getTableComment, so there's nothing to extract - change the commit message and PR title/description to explain why it's being moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delta-lake Delta Lake connector iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

3 participants