Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support user-defined time zone for mysql #24582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hqbhoho
Copy link

@hqbhoho hqbhoho commented Dec 26, 2024

Description

Add mysql.jdbc.force-connection-time-zone-to-session to support user-defined time zone.

Additional context and related issues

Now I will add -Duser.timezone=PRC in jvm.config, when I use mysql connector will throw exception like "com.mysql.cj.exceptions.CJException: Unknown or incorrect time zone: 'PRC'", I think should add a config to contorl whether turn on forceConnectionTimeZoneToSession and I can config connection-url like "jdbc:mysql://xxxx:3306?serverTimezone=Asia/Shanghai"

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Mysql
* Add support user-defined time zone for mysql

Copy link

cla-bot bot commented Dec 26, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
Copy link

cla-bot bot commented Dec 26, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@hqbhoho hqbhoho force-pushed the fix/add_user_defined_time_zone_for_mysql branch from 09d3f96 to 2054bf2 Compare December 26, 2024 10:57
Copy link

cla-bot bot commented Dec 26, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@hqbhoho
Copy link
Author

hqbhoho commented Dec 26, 2024

@ebyhr Could you help review it?

@ebyhr ebyhr requested a review from hashhar December 26, 2024 14:05
@hqbhoho
Copy link
Author

hqbhoho commented Dec 30, 2024

@hashhar Could you help review it? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant