Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CALL rollback_to_snapshot and add corresponding table procedure in Iceberg #24580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate CALL rollback_to_snapshot and add corresponding table procedure in Iceberg #24580

wants to merge 1 commit into from
+112 −10

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Dec 26, 2024 •
edited
Loading

Release notes

## Iceberg
* Add `rollback_to_snapshot` table procedure. The existing `system.rollback_to_snapshot` procedure is 
  deprecated and will be removed in a future release. ({issue}`24580`)

@cla-bot cla-bot bot added the cla-signed label Dec 26, 2024
@github-actions github-actions bot added docs iceberg Iceberg connector labels Dec 26, 2024
findinpath
findinpath reviewed Dec 30, 2024
View reviewed changes
...ceberg/src/main/java/io/trino/plugin/iceberg/procedure/RollbackToSnapshotTableProcedure.java
coordinatorOnly(),
ImmutableList.<PropertyMetadata<?>>builder()
.add(longProperty(
"snapshot_id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use snapshot_id property name explicitly in one of the tests

findinpath
findinpath reviewed Dec 30, 2024
View reviewed changes
...ino-iceberg/src/main/java/io/trino/plugin/iceberg/procedure/RollbackToSnapshotProcedure.java
@@ -31,6 +31,7 @@
import static java.lang.invoke.MethodHandles.lookup;
import static java.util.Objects.requireNonNull;

@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of a larger endeavor ?
If there are other follow-ups maybe it is worth creating a epic issue to track what else will be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

Assignees
No one assigned
Labels
cla-signed docs iceberg Iceberg connector
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @findinpath