Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Policy Agent material #607

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add Open Policy Agent material #607

merged 2 commits into from
Feb 6, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Feb 5, 2024

In the tools section and with a detailed blog post.

Also fyi @soenkeliebau

@cla-bot cla-bot bot added the cla-signed label Feb 5, 2024
@mosabua mosabua changed the title Add Open Policy Agent (WIP) Add Open Policy Agent Feb 5, 2024
_data/tools.yml Show resolved Hide resolved
@mosabua mosabua changed the title (WIP) Add Open Policy Agent Add Open Policy Agent material Feb 6, 2024
@mosabua mosabua requested review from bitsondatadev, sbernauer, vagaerg, colebow and dain and removed request for sbernauer February 6, 2024 01:18
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds very good, many thanks for writing this! Only a minor comment on the OPA logo

assets/images/logos/opa.png Outdated Show resolved Hide resolved
@vagaerg
Copy link
Member

vagaerg commented Feb 6, 2024

This looks great! Thanks @mosabua
I would only add that another item that's coming up is adding row level filtering and column masking - which we have already pushed to our fork bloomberg/trino#16 , and will look at upstreaming once the PR to rework the tests is done (trinodb/trino#20556 )

Copy link
Member

@vagaerg vagaerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Once you can have a look at the comments I left, I think we'll be good to go

@vagaerg
Copy link
Member

vagaerg commented Feb 6, 2024

@mosabua did you notice the artifacts on the logo that @sbernauer mentioned? There's some noise on the png

Copy link
Member

@vagaerg vagaerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks a lot @mosabua !

Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the blog is kind of underselling what you can do with this, why you'd care, etc. The story is fun to have but shouldn't be the bulk of the content IMO

_data/tools.yml Outdated Show resolved Hide resolved
_posts/2024-02-06-opa-arrived.md Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Feb 6, 2024

I feel like the blog is kind of underselling what you can do with this, why you'd care, etc. The story is fun to have but shouldn't be the bulk of the content IMO

I added a whole benefits section .. you think this is good now or did I miss something else @colebow ?

- Add as tool
- Add blog post with Trino Summit recap and update
- Fix Bloomberg links in summit recap post

Co-authored-by: Pablo Arteaga <[email protected]>
@mosabua mosabua merged commit ed70ec5 into trinodb:master Feb 6, 2024
5 checks passed
@mosabua mosabua deleted the opa branch February 6, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants