-
Notifications
You must be signed in to change notification settings - Fork 110
Contributor meetings
Manfred Moser edited this page Sep 3, 2025
·
104 revisions
The Trino Gateway project organizes regular meetings with contributors to improve collaboration with maintainers and among contributors. This space acts is used to plan upcoming meetings and provide meeting minutes after the event.
- Virtual meetings are held every second Wednesday, 6am PST.
- Anyone can attend.
- Contact Manfred Moser on Trino slack for an invite.
- Meeting details are also announced on slack in the trino-gateway-dev channel
- Topics can be suggested prior to the event by updating this page, message on the slack channel, or during the meeting
Attendees
mosabua, Chaho12, andythsu, RoeyoOgen, vishalya,
Topics, notes, action items, decisions
- Quick discussion of history server work and related UI
- Follow up to Trino metrics endpoint discussion from Trino contributor call and slack
- Future replacement in Trino Gateway for resource groups in Trino
- Rate limiting policy across resource groups in Trino
- Note to look at Kong for ideas https://konghq.com/products/kong-gateway
- Request to get release notes PR reviewed and approved to allow release to proceed
Attendees
mosabua, Chaho12, andythsu, oneonestar, vishalya, maswin
Topics, notes, action items, decisions
- Release notes and automation still in progress, need reviews
- Release blocked by missing availability from @martint or other BDLF who can help run release
- mosabua explained complexity around Trino release
- oneonestar - https://github.com/trinodb/trino-gateway/pull/740
- andy vishal jaeho and mosabua - lets merge and fix if we find anything - done now by mosabua
- https://github.com/trinodb/trino-gateway/pull/721 to merge, vishal to finish last change and then merge
- Vishal https://github.com/trinodb/trino-gateway/pull/741
- is an important refactor that needs everyones attention
- longer work so get in after 16
- Andy brought up topic to discuss cluster stats for all nodes and best approach, will look at trino endpoint expansion rather than implementing in gateway only
- cluster tags / label - https://github.com/trinodb/trino-gateway/issues/409
- Jaeho - https://github.com/trinodb/trino-gateway/issues/749
- Discussed in group, seems like a bug in Trino to some, Jaeho will investigate more
Attendees
Chaho12, andythsu, RoeyoOgen, oneonestar, vishalya,
Topics, notes, action items, decisions
- RoeyoOgen - Waiting for release
- andythsu - check on https://github.com/trinodb/trino-gateway/pull/741 PR regarding refactoring routingmanager
- vishalya - came back from holiday, will post refactoring PR soon
- Chaho12 - 502 Bad Gateway issue is very specific issue where cause of large headers blocked by nginx infront of Trino.
- oneonestar - maybe consider adding retry logic in Gateway like Trino does?
Attendees
mosabua, vishalya,
Chaho12, andythsu,
RoeyoOgen
Topics, notes, action items, decisions
-
mosabua - release blocked on merges and secret setup, working on it
-
Vishal - try to get in https://github.com/trinodb/trino-gateway/pull/721
-
Vishal - refactoring for JWT token, earlier parsing, hook to analyze query in http filter,
-
andy to work on cpu and memory for query based routing
-
jaeho - introduced weighting for query cpu and memory
-
trino history server - https://github.com/trinodb/trino/issues/26238
-
jaehoo - sometimes 502 error is returned by Trino Gateway, when failing to parsing answer from Trino, hits https://github.com/trinodb/trino-gateway/blob/main/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyResponseHandler.java#L43
-
seems to happen when query is cancelled or similar, but very rarely
Attendees
mosabua, vishalya,
Chaho12, andythsu,
RoeyoOgen, oneonestar
Topics, notes, action items, decisions
- mosabua - release notes PR, airlift update to unblock release
- roey - two PRs from last meeting 687 and 660, history server - meet with Erik
- vishal and andy - doing other work, andy to become maintainer after some more reviews and stuff after negative feedback yuya
- star, chimed in at 718 / 717 - server restart should not logout user
- roey https://github.com/trinodb/trino-gateway/pull/660 - jaeho approved, a fairly simple one
- roey https://github.com/trinodb/trino-gateway/pull/687 - awaiting conflict resolution. jaeho & vishal approved - yuya needs to resolve comments
- jaehoe https://github.com/trinodb/trino-gateway/pull/718
- Vishal cleaning up https://github.com/trinodb/trino-gateway/blob/main/gateway-ha/src/main/java/io/trino/gateway/proxyserver/MultiReadHttpServletRequest.java#L39
Attendees
mosabua, vishalya, Chaho12, andythsu, RoeyoOgen
Topics, notes, action items, decisions
- Remaining PRs we want merged for 16
- Commit and merge guidelines review
- Make sure to send docs - even for development setup stuff like https://github.com/trinodb/trino-gateway/pull/698
- Should add https://github.com/trinodb/trino-gateway/pull/660 to release, Vishal will review
- Also https://github.com/trinodb/trino-gateway/pull/687 - vishal , jaeho, mosabua will look,
- also ping Yuya for both
- https://github.com/trinodb/trino-gateway/pull/693 - mosabua to review docs and request from others (done)
- https://github.com/trinodb/trino-gateway/issues/708 - roey looking to fix
- mosabua add others - sync up on status on slack early next week, ping martin
- Vishal
- filtering and rate limiting - priority change so work delayed but
- query and user properties parsing centralized - will send PR
- will also work with Roey
- Redis use incoming for that feature as well
Attendees
vishalya, Chaho12, oneonestar, andythsu, RoeyoOgen
Topics, notes, action items, decisions
- Jaeho - discussed the unit testing best practices, try to avoid sleep calls
- Roey - Needs the PR to be merged before release #687, #700
- Vishal - Overall idea about the rate limiting and goal is to stay as close to the resource groups as possible and general discussion on modules
- Andy - Needs review/merge before release for the PRs #695 , #697, #698 pending merge before release , discussed the architectural diagram for rate limiting module. Will continue the discussion on the issue, it'd be useful if we could get query's resource consumption from jmx/other mechanisms for gateway to perform better rate limiting we could also implement auto-scaling in gateway
Attendees
mosabua, oneonestar, vishalya, andythsu, Chaho12, RoeyoOgen, Vishnu Karmasetty
Topics, notes, action items, decisions
- Plan for 16?
- Star - dep updates - https://github.com/trinodb/trino-gateway/pull/689
- Roey to work on https://github.com/trinodb/trino-gateway/pull/687 to get merged before release
- Vishal - rate metering with central state stored in Redis/valkey - roadmap for larger effort
- Star - https://github.com/trinodb/trino-gateway/issues/679 spooling protocol - read and ask wendigo, best would be if coordinator id is embedded in URL
Attendees
mosabua, oneonestar, vishalya, andythsu, Chaho12, Edenk
Topics, notes, action items, decisions
- next release when manfred available
- tarball PR okay to proceed but rename folder and review
- Edenk https://github.com/trinodb/trino-gateway/issues/658
cancelled
Attendees
mosabua, oneonestar, vishalya, andythsu, RoeyoOgen
Topics, notes, action items, decisions
- Date to plan for Trino Gateway 16, skip or release as soon as possible, decided to release as soon as possible
- Roey
- https://github.com/trinodb/trino-gateway/pull/654
- https://github.com/trinodb/trino-gateway/pull/660
- He will also work on https://github.com/trinodb/trino-gateway/issues/658 next
- third PR coming for default fall back routing group other than "adhoc"
- Andy - question to star - progress on exposing stats in new Trino endpoint, overload v1/info or not - to file issue in trino to discuss details
- Tarball PR, we will chime in about motivation, if it makes sense PR also needs docs, needs docker container, need to ask what benefits are expected
- https://github.com/trinodb/trino-gateway/pull/664 just needs review, should be easy
- https://github.com/trinodb/trino-gateway/pull/651 - no concerns but definitely needs test
Attendees
mosabua, oneonestar, Chaho12, vishalya, andythsu, RoeyoOgen
Topics, notes, action items, decisions
- mosabua - willmostly becoming mostly inactive
- db PR from willmostly should be revived and merged, https://github.com/trinodb/trino-gateway/pull/635, mosabua might end up doing it
- RoeyoOgen - https://github.com/trinodb/trino-gateway/pull/654
- andythsu and vishalya - work on https://github.com/trinodb/trino-gateway/pull/607
- https://github.com/trinodb/trino-gateway/pull/539 - andythsu and vishalya to ping willmostly
- discusses resource groups deprecation and think about UI move to Trino, mosabua filed https://github.com/trinodb/trino-gateway/issues/656
Attendees
mosabua, willmostly, oneonestar, Chaho12, vishalya, andythsu, RoeyoOgen
Topics, notes, action items, decisions
- Trino Gateway 15 is out
- mosabua - status update, now at Chainguard, will continue to do Trino Gateway as feasible
- Java 24
- Coming now in March
- Should be part of next release provided Trino also updates and releases
- RoeyoOgen
- no way to limit queries on runtime, wants to use Trino Gateway to update session properties
- #646
- Discussion resulted in agreement to proceed with this as optional feature
- willmostly
- #629
- resource groups, api that interacts with db resources groups, Trino Gateway is mgt UI for resource groups,
- does not really use it, weird mismatch
- creates incompatibility with flyway upgrades from Trino and Trino Gateway
- problematic with different Trino versions
- bad design and code, not suitable for Trino Gateway
- group agreed to remove, leave deletion of tables as manual step for upgrade, breaking change
- Discussion on proxyTo and externalURL
- needs update in the UI code, and docs for the difference
- proxyTo - where TGW redirects to (can be internal private IP), needed for routing where Trino Gateway is only externally accessible system
- externalURL - actual URL of a Trino cluster that is accessible from outside world, needed for accessing Trino UI for query stuff
- PR about H2 security issue and upgrade
- decided to remove it and get tests migrated to use PostgreSql - mosabua to chime in at PR, done
Attendees
mosabua, willmostly, oneonestar, Chaho12, vishalya, andythsu, RoeyoOgen, dprophet
Topics, notes, action items, decisions
- PR to store in db, problem with array data types, ready for review, ordering is explicitly required now, migration just adds table, optional feature, figure out how to migrate, need to document how to take rules from yaml to db, use the new create rules API that is included willmostly will add, reload every minute, configurable,
- Release 15 planning
- Java 24 note
- https://github.com/trinodb/trino-gateway/pull/607
- PR from andy is ready for review - discussion around cookie based router
- #630 - for 15
- Discussion around Trino to Trino connector
Attendees
mosabua, willmostly, oneonestar, Chaho12, nineinchnick, Roey Ogen
Topics, notes, action items, decisions
- Trino Gateway 14 release recap and first usage feedback
- db change script and flyway - fought each other
- willmostly to check and do clean up of quickstart
- New release cadence - every 4 week, add to calendar - no, but pin to slack channel
- Caching - Roey
- https://github.com/trinodb/trino-gateway/issues/606
- including blocking queries for people to just hit refresh on a dashboard or so
- deally we want to keep Trino Gateway simple so cache would have to be per user
- potentially use redis/valkey
- Discussed security implications and other complexities, Roey will try to try things up more
- Group agrees that this is a a worthwhile feature to look at adding, must be optional and configurable
- Query filtering
- Roey is migrating from impala to trino
- wants to prevent simple queries without join
- query interceptor like denodo
- willmostly - scenario comes up regularly, had hack in past, blackhole routing group approach
- should have custom response with useful message for user
- Chaho12 - could not customize error message, potentially need to update Trino client as part of the protocol
- potentially also have an exploration
- willmostly recommends to use data in https://github.com/trinodb/trino-gateway/blob/dfcc2dd7257deb6c080901cb6fadf8faf378fbe9/gateway-ha/src/main/java/io/trino/gateway/ha/router/TrinoQueryProperties.java#L439
- Group agrees that this is a a worthwhile feature to look at adding, must be optional and configurable
- willmostly
- using db for routing rules storage, ended being a fairly large change set
- separate table with name, description.... , PR incoming
- oneonestar
- docker image refactor, adjust for config file name change,
- toast pr review - roey will ask web dev on his team to get started for experience
- ebyhr is no longer working on Trino Gateway
Attendees
mosabua, willmostly, vishalya, andythsu, oneonestar, alaturqua
Topics, notes, action items, decisions
- 14 release
- jmx and openmetrics should be merged
- UI PR close to merge
- Mosabua to review and merge https://github.com/trinodb/trino-gateway/pull/595 (done)
- Discussed Oracle db / container issue
- Decided to merge PR that disables for local build on ARM
- Need to research for potential alternative containers, problem currently is license, version, and authentication need
- Discussed release cadence
- Agreed to switch to timed release rather than discussion and features
- Will move to monthly after 14 shipped
-
https://github.com/trinodb/trino-gateway/pull/607
- Vishal and Will to review and help Andy
- Discussed database changes
- Agreed to create new database revision with each change rather than with each Trino Gateway release
Attendees
mosabua, Chaho12, willmostly, vishalya, andythsu, oneonestar, wendigo, Simian You (Doordash)
Topics, notes, action items, decisions
- mosabua
- Standardizing on a better config file name name than gateway-ha-config.yml
- for example config.yml only, or trino-gateway-config.yml
- https://github.com/trinodb/trino-gateway/pull/586
- Discussed and agreed on
config.yaml - https://github.com/trinodb/trino-gateway/issues/598
- wendigo
- proposal to use launcher from airlift
- discussed and found that due to the yaml usage for config that is currently not possible
- we would also have to discuss benefits
- vishalya
- Filter proposal at https://github.com/trinodb/trino-gateway/issues/591
- wendigo very knowledgeable
- In principal we want to go ahead
- At least sample implementation and docs
- HTTP filter, already possible as part of airlift, use jakarta filters
- willmostly
- heads up - some db changes are on his horizon,
- storing rules in the db - new table,
- some configs to become specific per Trino cluster, such as the xforwarded header
- Discussed flyway setup, willmostly to check but we should NOT have automatic downgrades, if wrong schema , nodes should fail to start
- oneonestar
- health check API and PR to load all modules by default, need review
- Team agreed in principal, reviews to follow
- https://github.com/trinodb/trino-gateway/pull/597
- https://github.com/trinodb/trino-gateway/pull/595
- andythsu
- testing of routing rules in CI or in running application, upgrade broke some routing
- Simian
- will ask for approval for Doordash to be added to users page
Attendees
mosabua, Chaho12, willmostly, vishalya, andythsu, oneonestar
Topics, notes, action items, decisions
- mosabua
- Presentation from Trino Summit is live, with slides and video, 200 views so far
- https://trinodb.github.io/trino-gateway/resources/#opening-up-the-trino-gateway
- https://trinodb.github.io/trino-gateway/users/
- UX issues found - filed https://github.com/trinodb/trino-gateway/issues/585
- PR and issue backlog work
- Working towards 14 after round of reviews and merges
- Chat about Netflix presentation
- Scale and such
- Aiming to look at Trino Gateway
- vishalya and mosabua to invite speaker to join dev sync to chat
- Chaho12
- external routing needs a timeout option
- had a hard time debugging issue where another service used in the external routing server had timing issues
- Created https://github.com/trinodb/trino-gateway/pull/580
- request to make client timeouts consistent - mosabua to initiate and coordinate
- willmostly
- easyrules removal PR is ready again, looking for final review
- also working on JMX and router rules UI PRs
- We need to add some more monitoring/metrics, for example response time overall, discussion with others
- vishal
- looking at more capabilities to validate headers some more, protecting endpoints
- still in design, in Trino Gateway or not?,
- team requested more details in an issue
- andythsu
- how to instrument jetty for more metrics
- willmostly and mosabua - lots already done in airlift, ask wendigo for more info if needed
- some info in https://github.com/trinodb/trino/pull/21089 should also apply in gateway
- oneonestar
- Had some issues with k8s and the fact that we have no healthcheck endpoint
- team agreed we need one or two
- should replace using the UI as healtcheck as currently done in chart
- oneonestar to send PR