Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Engine 2.0 (alpha) #1575

Open
wants to merge 346 commits into
base: main
Choose a base branch
from
Open

Run Engine 2.0 (alpha) #1575

wants to merge 346 commits into from
+24,020 −2,067

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Dec 17, 2024

Good luck @coderabbitai

matt-aitken and others added 30 commits November 5, 2024 15:10
@matt-aitken
Work on dealing with attempts that fail
d01b888
@nicktrn
runs triggered via run engine should be V2
3194257
@nicktrn
current unmanaged deployment label
c66d3fe
@nicktrn
schema changes
79d4432
@nicktrn
run engine base service extension
8089397
@nicktrn
Merge remote-tracking branch 'origin/main' into run-engine-2
d036d7a
@matt-aitken
Improved the triggerAndWait test to start the parentRun before trigge…
2dab2ea 
…ring the child
@matt-aitken
Simplified the tests so there’s less repeated checks, keep them more …
8c3cabf 
…focused
@matt-aitken
Failed run test passing
cb26957
@nicktrn
hidden worker groups
dc4a88c
@nicktrn
feature flag helpers
6bb7a4c
@nicktrn
add basic worker package
a7ecfc9
@nicktrn
add worker group services
41eb240
@nicktrn
get master queue from default worker group on trigger
accee54
@nicktrn
basic worker api routes
a6a7b40
@nicktrn
add worker group tests
a035ab1
@matt-aitken
Improved attempt completing and made a test for retries
d36b2d5
@matt-aitken
Merge remote-tracking branch 'origin/main' into run-engine-2
a958af2
@matt-aitken
Add a delayed run test
cca3a5b
@nicktrn
rename and implement lastDequeueAt
8cda15c
@matt-aitken
Renamed checkpointThresholdMs, added a stub for createCheckpoint, and…
0160c97 
… improved some types
@matt-aitken
Fix tests
dbc28a8
@nicktrn
rename complete attempt result
176407b
@matt-aitken
When an attempt fails snapshot goes to “PENDING_EXECUTING”. Fixes for…
5cb1fef 
… the attempt number
@matt-aitken
Cancelling a run. Heartbeat function exposed
318d3e0
@matt-aitken
Cancelling test now includes a running child task
29e8228
@nicktrn
don't await the unawaitable
3668cf5
@nicktrn
simplify image build and add node-22 runtime
a0dcd78
@nicktrn
new worker action api routes
cba4fca
@nicktrn
deprecate several context props
b10094f
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 18, 2024 •
edited
Loading

@trigger.dev/build

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1575

@trigger.dev/core

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1575

trigger.dev

npm i https://pkg.pr.new/triggerdotdev/trigger.dev@1575

@trigger.dev/react-hooks

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1575

@trigger.dev/rsc

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/rsc@1575

@trigger.dev/worker

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/worker@1575

@trigger.dev/sdk

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1575

commit: 45a829e

nicktrn and others added 20 commits December 20, 2024 13:16
@nicktrn
use default machine preset from platform package
56979e6
@nicktrn
worker instances plural in schema
ae6a473
@nicktrn
disable pnpm update notifications
482a98d
@nicktrn
return worker group details from connect call
d3386e2
@nicktrn
add workers admin route
7d382ac
@nicktrn
fix heartbeat route return type
a759bf7
@nicktrn
move deployment labels to core apps
927edea
@nicktrn
refactor run controller env schema
3d21147
@matt-aitken
Add firstAttemptStartedAt to TaskRun
4f954b2
@matt-aitken
RunEngine 2.0 batch trigger support (#1581)
3d4068a 
* Make it clear when BatchTriggerV2Service is used

* Copy of BatchTriggerV2Service

* WIP batch triggering

* Allow blocking a run with multiple waitpoints at once. Made it atomic

* Removed unused param

* New batch service

* Pass through the parentRunId and resumeParentOnCompletion

* Use the new batch service, and correct trigger task version

* Force V1 engine if using BatchTriggerV2Service, we’ve already done the check at this point

* Removed the $transaction and early exit if nothing changed

* Adedd a simple batch task to the hello world reference catalog

* Fix for batch waits not working

* Added parentRunId in a couple more places

* Removed waitForBatch log

* Added another parentRunId

* Expanded the example to include all the different triggers
@matt-aitken
More changes to blocking to support continuing after idempotent compl…
0642c9c 
…eted runs
@matt-aitken
Fix for the wrong type when blocking a run
fdf0bf6
@nicktrn
remove @Map
d6e8743
@nicktrn
optimise worker auth query
9d24fc1
@nicktrn
add engine version header to core api client requests
446a94f
@nicktrn
remove unique constraint for default group id
ca82d75
@nicktrn
consolidate migrations
3c67350
@nicktrn
the first managed worker becomes the global default
f961a75
@nicktrn
Merge remote-tracking branch 'origin/main' into run-engine-2
3e2687e
@matt-aitken
Debug events off by default, added an admin toggle to show them
45a829e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-aitken matt-aitken matt-aitken left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicktrn @matt-aitken