Fix visudo lockout false positive on include files #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
approved these changes
Dec 15, 2025
Collaborator
There was a problem hiding this comment.
Thanks! There could still be false positives if the rule that allows visudo is in /etc/sudoers.d/, but this should prevent most false positives. And avoiding all false positives would be a lot more complicated and I don't think it would be worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #1329.
When editing a file in
/etc/sudoers.d/,visudowas checking if that specific file allowed the user to runvisudo. This often led to unnecessary lockouts.The fix implements the suggestion by @squell to skip the lockout check when the file being edited is not
/etc/sudoers.