Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty favicon.ico to fix CI #623

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add empty favicon.ico
To avoid `ActionController::RoutingError` from headless chrome for Rails < 7.2.
Like the following:
```
Failures:

  1) User views ember app using route helper
     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"

     ActionController::RoutingError:
       No route matches [GET] "/favicon.ico"
```
tricknotes committed Sep 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit df2ab2908656e9a6b1bf9cc5fcedde6d8f776619
Empty file added spec/dummy/public/favicon.ico
Empty file.