refactor(trading): refactor buy section to the new reducer #17175
Conversation
| @@ -1,243 +0,0 @@ | |||
| import { BuyTrade, BuyTradeQuoteRequest, CryptoId } from 'invity-api'; | |||
There was a problem hiding this comment.
Deprecated - buy actions are tested in suite-common.
| const AVAILABLE_DEVICE = getSuiteDevice({ available: true, connected: true }); | ||
|
|
||
| export const VERIFY_BUY_ADDRESS_FIXTURES = [ |
There was a problem hiding this comment.
The verifying address was refactored to the verifyAddressThunk - tested in suite-common.
| @@ -58,25 +55,6 @@ describe('Trading Common Actions', () => { | |||
| jest.clearAllMocks(); | |||
| }); | |||
|
|
|||
| VERIFY_BUY_ADDRESS_FIXTURES.forEach(f => { | |||
There was a problem hiding this comment.
-> verifyAddressThunk, also tested there.
| @@ -1,171 +0,0 @@ | |||
| import { | |||
There was a problem hiding this comment.
Deprecated - refactored version is in suite-common
| @@ -85,14 +89,6 @@ export const tradingMiddleware = | |||
| ); | |||
| } | |||
|
|
|||
| if (isDifferentAccount || !buyInfo) { | |||
There was a problem hiding this comment.
Loading is handled by loadInitialDataThunk
| }; | ||
|
|
||
| // TODO: trading - is it possible to have buyInfo before render? | ||
| useEffect(() => { |
There was a problem hiding this comment.
Load initial data - before it was in middleware.
| useTradingModalCrypto({ | ||
| receiveCurrency: values.cryptoSelect?.value as CryptoId | undefined, | ||
| }); | ||
|
|
||
| // set payment form method based on quotes | ||
| useEffect(() => { |
There was a problem hiding this comment.
Setting payment method, extract of the handleRequestThunk
| @@ -402,6 +285,19 @@ export const useTradingBuyForm = ({ | |||
| ], | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
Added loading status immediately after form change.
| @@ -481,15 +378,6 @@ export const useTradingBuyForm = ({ | |||
| ], | |||
| ); | |||
|
|
|||
| // eslint-disable-next-line arrow-body-style | |||
There was a problem hiding this comment.
Moved to useTradingHandleChange.
| @@ -141,130 +142,12 @@ export const useTradingBuyForm = ({ | |||
| }, | |||
| }); | |||
|
|
|||
| const getQuotesRequest = useCallback( | |||
There was a problem hiding this comment.
Moved to buyThunks.handleRequestThunk
|
Some issues with test - https://github.com/trezor/trezor-suite/actions/runs/13496626997/job/37705568914#step:6:473 |
Description
Connect the current trading reducer to the new one.
Related Issue
Resolve #17174