Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/bump foundation deps 2025.02 #16880

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Feb 6, 2025

Description

Update most Foundation-related dependencies.

major version:

  • electron
  • electron-builder

minor version:

  • webpack
  • @eslint/js
  • eslint
  • eslint-plugin-jest
  • eslint-plugin-react
  • typescript-eslint
  • openpgp

patch version:

  • idb
  • systeminformation
  • uuid

not updated:

  • tiny-secp256k1 TODO in #12261
  • electron-store blocked by #14482

ℹ️ For reference, last bump foundation deps PR was #16258
👁️ I skimmed through all code changes except eslint-related packages and electron; found nothing suspicious ✅

Related Issue

Resolve #16615

QA

👁️ Besides CI checks, I have tested locally:

  • suite dev web
    • app builds & runs
    • resetting app storage (test idb persistence)
  • suite dev desktop
    • app builds & runs
    • systeminformation output in debug logs
    • tor
  • suite desktop linux build & windows build
    • app builds & runs
    • app update works
    • resetting app storage (test idb persistence)

@coderabbitai ignore

@trezor trezor deleted a comment from coderabbitai bot Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 24
  • More info

Learn more about 𝝠 Expo Github Action

Copy link

socket-security bot commented Feb 6, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@electron/[email protected], npm/[email protected], npm/@electron/[email protected], npm/@electron/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Lemonexe
Copy link
Contributor Author

Lemonexe commented Feb 7, 2025

@SocketSecurity ignore npm/@electron/[email protected]
Ok, it's a legitimate usage of child_process

@SocketSecurity ignore npm/[email protected]
Ok, it's a legitimate usage of child_process

@SocketSecurity ignore npm/@electron/[email protected]
Ok, it's a legitimate usage of child_process

@SocketSecurity ignore npm/@electron/[email protected]
The Http dependency in question is a fork of node-gyp, comes from @electron/rebuild, with this reason. TL;DR: temporary monkeypatch to support Node12 until they cut it off in next major ver.
I checked the fork since they diverged from nodejs/node-gyp, looks OK.

@peter-sanderson
Copy link
Contributor

gfo 
gco chore/bump-foundation-deps-2025.02 
git checkout origin/develop -- yarn.lock # to revert yarn to the develop
yarn
yarn dedupe
git add .

=> produces empty diff ✔️

@Lemonexe Lemonexe marked this pull request as ready for review February 7, 2025 12:06
@Lemonexe Lemonexe merged commit eab0cc7 into develop Feb 7, 2025
79 checks passed
@Lemonexe Lemonexe deleted the chore/bump-foundation-deps-2025.02 branch February 7, 2025 12:22
signtoolOptions: {
publisherName: ['SatoshiLabs, s.r.o.', 'Trezor Company s.r.o.'],
sign: '../suite-desktop-core/scripts/sign-windows.ts',
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settings moved to signtoolOptions in electron-userland/electron-builder#8582
signDlls setting was removed -> now it behaves as always true (see the diff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump foundation deps (2025.02)
2 participants