-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/bump foundation deps 2025.02 #16880
Conversation
🚀 Expo preview is ready!
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/@electron/[email protected] @SocketSecurity ignore npm/[email protected] @SocketSecurity ignore npm/@electron/[email protected] @SocketSecurity ignore npm/@electron/[email protected] |
gfo
gco chore/bump-foundation-deps-2025.02
git checkout origin/develop -- yarn.lock # to revert yarn to the develop
yarn
yarn dedupe
git add . => produces empty diff ✔️ |
signtoolOptions: { | ||
publisherName: ['SatoshiLabs, s.r.o.', 'Trezor Company s.r.o.'], | ||
sign: '../suite-desktop-core/scripts/sign-windows.ts', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
settings moved to signtoolOptions
in electron-userland/electron-builder#8582
signDlls
setting was removed -> now it behaves as always true
(see the diff)
Description
Update most Foundation-related dependencies.
major version:
minor version:
patch version:
not updated:
tiny-secp256k1
TODO in #12261electron-store
blocked by #14482ℹ️ For reference, last bump foundation deps PR was #16258
👁️ I skimmed through all code changes except eslint-related packages and
electron
; found nothing suspicious ✅Related Issue
Resolve #16615
QA
👁️ Besides CI checks, I have tested locally:
idb
persistence)systeminformation
output in debug logsidb
persistence)@coderabbitai ignore