fix(connect): eip1559 correct maxFeePerGas #15907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykan
requested review from
mroz22,
szymonlesisz and
marekrjpolak
as code owners
mroz22
approved these changes
Dec 11, 2024
mroz22
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in EIP1559 message signing, which led to a mismatch between the FW message and Ethereumjs serialized message.
A previous fix in #15322 was applied, but the idea behind it was completely incorrect, the actual original issue was just that the boolean condition was reversed.
Several steps are taken to prevent this in the future:
ethereumSignTxtoserializeEthereumTx, which works with Trezor's message typesserializeEthereumTxwas improved. It no longer uses type casts so the input type is actually checked. CorrectCommonobject is loaded based onchainIdserializeEthereumTxwere improved, they also validate thefromaddress and a test case for EIP-1559 was added