Convert suite settings (coins, custom-firmware) + refactors desktop pipeline #15869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor refactoring some verification commented out and will be part of future refactoring
adds logic to use correct API url based on web/desktop/local/CI removes flakyness of Coins test
better matrix move docker pull from tests step to improve readability pull only what is need Attach playwright report for devs who dont have currents add --forbid-only to both pipelines
Vere-Grey
commented
Dec 10, 2024
| GITHUB_ACTION: true | ||
| CURRENTS_PROJECT_ID: Og0NOQ | ||
| CURRENTS_RECORD_KEY: ${{ secrets.CURRENTS_RECORD_KEY }} | ||
| CURRENTS_CI_BUILD_ID: pr-run-${{github.run_id}} | ||
| run: | | ||
| docker compose up -d ${{ matrix.CONTAINERS }} | ||
| echo "Starting Playwright Web test group ${TEST_GROUP}" | ||
| yarn workspace @trezor/suite-desktop-core test:e2e:web --grep=${TEST_GROUP} | ||
| echo "Starting Playwright Web test group ${{ matrix.TEST_GROUP }}" |
There was a problem hiding this comment.
Unify how vars are passed to bash and adds safety net --forbid-only. Playwright docs: Whether to disallow test.only. Useful on CI.
Vere-Grey
commented
Dec 10, 2024
| # - TEST_GROUP: "@group=other" | ||
| # CONTAINERS: "trezor-user-env-unix" | ||
| - TEST_GROUP: "@group=wallet" | ||
| CONTAINERS: "trezor-user-env-unix bitcoin-regtest" | ||
|
|
||
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
Our web pipeline uses different checkout:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{github.event.after}}
fetch-depth: 2
Any preferences?
Vere-Grey
commented
Dec 10, 2024
| @@ -34,7 +36,7 @@ const config: PlaywrightTestConfig = { | |||
| reporter: process.env.GITHUB_ACTION | |||
| ? [['list'], ['@currents/playwright'], ['html', { open: 'never' }]] | |||
| : [['list'], ['html', { open: 'never' }]], | |||
| timeout: 1000 * 60 * 5, | |||
| timeout: process.env.GITHUB_ACTION ? timeoutCIRun : timeoutLocalRun, | |||
There was a problem hiding this comment.
We want locally tests to fail fast during troubleshooting.
Vere-Grey
commented
Dec 10, 2024
Comment on lines
+106
to
+115
| export const getApiUrl = (webBaseUrl: string | undefined, testInfo: TestInfo) => { | ||
| const electronApiURL = 'file:///'; | ||
| const apiURL = | ||
| testInfo.project.name === PlaywrightProjects.Desktop ? electronApiURL : webBaseUrl; | ||
| if (!apiURL) { | ||
| throw new Error('apiURL is not defined'); | ||
| } | ||
|
|
||
| return apiURL; | ||
| }; |
There was a problem hiding this comment.
might need update once i see first ci run
Vere-Grey
commented
Dec 10, 2024
Comment on lines
+21
to
+26
| await test.step('Select the custom firmware', async () => { | ||
| const fileChooserPromise = page.waitForEvent('filechooser'); | ||
| await page.getByTestId('@firmware-modal/input-area').click(); | ||
| const fileChooser = await fileChooserPromise; | ||
| await fileChooser.setFiles(firmwarePath); | ||
| }); |
There was a problem hiding this comment.
I am really impressed this works in desktop. Well done playwright
HajekOndrej
approved these changes
Dec 10, 2024
HajekOndrej
deleted the
feat-convert-cy-pw-suite-settings-custom-firmware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts:
settings/coins.test.ts
settings/custom-firmware.test.ts
Fixes:
settings/t2b1-device-settings.test.ts
Refactors and updates desktop pipeline. Works with tags and is updated according to the web one,