Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cardano): enable tagged sets in tx serialization #15850

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

slowbackspace
Copy link
Contributor

Description

This is the first of two PRs preparing Suite for the upcoming Cardano hard fork. Key updates include:

  1. Transaction Serialization
    Post hard fork, all transactions must be serialized using tagged CBOR sets. This is already supported by Trezor/Connect (via tagCborSets param in trezorConnect.cardanoSignTransaction) and is now also supported by @fivebinaries/coinselection v3.

  2. Staking Rewards Withdrawal
    Users withdrawing staking rewards will need to make a governance decision by selecting one of three options:

    • A vote of no confidence
    • Abstaining
    • Delegating to a DRep

Changes in this PR

  • Upgraded cardano coinselection lib to support tagged cbor sets and voting certificate
  • Utility functions for transforming vote delegation certificates (these will be used in the next PR introducing UI for governance):
    • updated prepareCertificates to convert from trezor-connect certificate format into coinselection lib format
    • introduced getVotingCertificates for creating voting cert in trezor connect format

Next Steps

The next PR will focus on introducing u UI to allow users to select their preferred governance participation option before proceeding with staking reward withdrawals.

@slowbackspace slowbackspace force-pushed the chore/cardano-tagged-cbor-sets branch from e44b0bb to aa0e06b Compare December 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant