feat(suite-native): make device switcher work without devicestate #15844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
vytick
force-pushed
the
feat/native/device-switcher-improvements
branch
from
e328856 to
b2c1b37
Compare
Nodonisko
previously requested changes
Dec 9, 2024
| @@ -61,7 +61,7 @@ export const DeviceItemContent = React.memo( | |||
|
|
|||
| const device = useSelectorDeepComparison((state: DeviceRootState) => { | |||
| // select only what is needed to avoid unnecessary rerenders | |||
| const d = selectDeviceByState(state, deviceState); | |||
| const d = deviceState ? selectDeviceByState(state, deviceState) : undefined; | |||
| @@ -38,12 +38,13 @@ export const SimpleDeviceItemContent = React.memo( | |||
| const { applyStyle } = useNativeStyles(); | |||
| const deviceIsConnected = useSelector( | |||
| // selecting only connected device property prevents unnecessary rerenders | |||
| (state: DeviceRootState) => selectDeviceByState(state, deviceState)?.connected ?? null, | |||
| (state: DeviceRootState) => | |||
| deviceState ? selectDeviceByState(state, deviceState)?.connected : undefined, | |||
There was a problem hiding this comment.
How does this make any difference? selectDeviceByState returns undefined anyway
There was a problem hiding this comment.
but it expects devicestate as defined
There was a problem hiding this comment.
this calls the selector in case deviceState is defined (expected by selectDeviceByState which I didnt want to change) or returns undefined otherwise
There was a problem hiding this comment.
I think it might be fine to make selector to accept also undefined, WDYT? We will probably need it to use like this in more places no?
There was a problem hiding this comment.
Not that many places, actually. Right, it seems safe to change:
Nodonisko
approved these changes
Dec 13, 2024
trezor-ci
force-pushed
the
feat/native/device-switcher-improvements
branch
from
34f6539 to
92ffa07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make device switcher to show content even in case there is no deviceState for the device.
Related Issue
Part of #15733