fix(suite): Fix buy/sell/dca buttons #15795
Closed
+85
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvaclavik
force-pushed
the
fix-invity-buttons
branch
from
5badd87 to
7d2f699
Compare
|
I don't think this is a good idea. Select bar is a form component, not a navigation one. I'd just create the Subtabs component. Or use Tabs here, since it's supposed to be there anyway. |
jvaclavik
force-pushed
the
fix-invity-buttons
branch
from
7d2f699 to
1d62467
Compare
jvaclavik
force-pushed
the
fix-invity-buttons
branch
from
1d62467 to
44e0713
Compare
adamhavel
requested changes
Dec 10, 2024
| @@ -156,6 +163,7 @@ type ValueTypes = number | string | boolean; | |||
| type Option<V extends ValueTypes> = { | |||
| label: ReactNode; | |||
| value: V; | |||
| icon?: IconName; | |||
|
|
||
| export const allowedSelectBarFrameProps = ['margin', 'width'] as const satisfies FramePropsKeys[]; | ||
| type AllowedFrameProps = Pick<FrameProps, (typeof allowedSelectBarFrameProps)[number]>; | ||
|
|
||
| export const fillTypes = ['none', 'default'] as const; |
There was a problem hiding this comment.
Perhaps we should create a common fill types like for other props, it's used in many components.
| }>` | ||
| position: relative; | ||
| display: grid; | ||
| grid-auto-columns: ${({ $optionsCount }) => `minmax(${getPuckWidth($optionsCount)}, 1fr)`}; | ||
| grid-auto-flow: column; | ||
| gap: ${spacingsPx.xxs}; | ||
| padding: ${spacingsPx.xxs}; | ||
| background: ${mapElevationToBackground}; | ||
| background: ${({ $fillType, theme, $elevation }) => |
There was a problem hiding this comment.
Do it the other way around, unset the background when fillType is none. Then you don't have to pass all the props to the mapElevationToBackground.
|
Already fixed in other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve
Screenshots:
before
after
