chore: add pre-commit hook that does eslint before commit only on files that has been changed #15753
+46
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
commented
Dec 3, 2024
|
|
||
| if ! bash "$script_dir/eslint.sh"; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
@jvaclavik you can add precommit hook for commit message after that here. I tried and got some ugly error so I leave it to you :D
peter-sanderson
force-pushed
the
hook-pre-commit-eslint-fix
branch
from
dd1acde
to
f8d742c
Compare
peter-sanderson
commented
Dec 3, 2024
| @@ -84,17 +85,8 @@ | |||
| "ios": "yarn native:ios", | |||
| "p": "yarn native:prebuild", | |||
| "ports": "yarn native:reverse-ports", | |||
| "s": "yarn native:start" | |||
| }, | |||
| "lint-staged": { | |||
There was a problem hiding this comment.
This seems to me as dead code. I have checked the lint-staged library and I do not think we need it. The simple script shall work the same way. Or am I missing something?
There was a problem hiding this comment.
When I came across lint-staged I tried to make it work, but didn't succeed.
peter-sanderson
commented
Dec 3, 2024
|
|
||
| script_dir=$(dirname "$(realpath "$0")") | ||
|
|
||
| if ! bash "$script_dir/eslint.sh"; then |
There was a problem hiding this comment.
Also prettier shall be somehow added
|
🚀 Expo preview is ready!
|
martykan
reviewed
Dec 3, 2024
.husky/eslint.sh
Outdated
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
|
|
|||
| STAGED_FILED=$(git diff --cached --name-only --diff-filter=d | grep '(\.js\|\.jsx$\|\.ts\|\.tsx)$') | |||
peter-sanderson
force-pushed
the
hook-pre-commit-eslint-fix
branch
2 times, most recently
from
ff6b39f
to
fbf38a2
Compare
Lemonexe
reviewed
Dec 4, 2024
that has been changed
peter-sanderson
force-pushed
the
hook-pre-commit-eslint-fix
branch
from
fbf38a2
to
37e503d
Compare
peter-sanderson
commented
Dec 4, 2024
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "_______ Hooks _______": "Yarn hooks.", | |||
| "postinstall": "yarn run patch-package", | |||
| "postinstall": "yarn run patch-package && husky", | |||
There was a problem hiding this comment.
# Yarn doesn't support `prepare`
See: https://typicode.github.io/husky/how-to.html#manual-setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some reads on topic: