Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connect): ignore disposed error in devicelist #15706

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(connect): ignore disposed error in devicelist #15706

merged 1 commit into from
Dec 3, 2024

Conversation

martykan
Copy link
Member

@martykan martykan commented Dec 3, 2024 •
edited
Loading

Description

This should help get rid of the Disposed error in init tests.

@martykan martykan force-pushed the connect-e2e-dispose-silence branch 2 times, most recently from 11188ee to 6877cc0 Compare December 3, 2024 10:34
@martykan martykan changed the title test(connect): ignore disposed error in tests fix(connect): ignore disposed error in devicelist Dec 3, 2024
@marekrjpolak
Copy link
Contributor

My observation:

  • catch() in waitForDevices would probably cause continuing of initializeTransport and emitting TRANSPORT.START even in case of dispose.
  • catch() in createReconnectPromise is probably fine, but I believe we can catch everything as it's only assigned to initPromise which should (probably?) never throw.

Also, this will be refactored a lot in #15324.

@marekrjpolak marekrjpolak force-pushed the connect-e2e-dispose-silence branch from bde5bd8 to b72300f Compare December 3, 2024 13:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12141112706

@martykan martykan marked this pull request as ready for review December 3, 2024 14:40
@martykan
Copy link
Member Author

martykan commented Dec 3, 2024

Let's try this and keep monitoring the tests continually

@martykan martykan merged commit a0270b1 into develop Dec 3, 2024
54 checks passed
@martykan martykan deleted the connect-e2e-dispose-silence branch December 3, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekrjpolak marekrjpolak marekrjpolak approved these changes

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martykan @marekrjpolak