Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not merge nor release! Mobile enable solana on mobile via messages #15701

Closed
wants to merge 1 commit into from
Closed

Do not merge nor release! Mobile enable solana on mobile via messages #15701

wants to merge 1 commit into from

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Dec 2, 2024 •
edited
Loading

Enable Solana on mobile via message system.

⚠️ Do not merge unless decided to release Solana on mobile in between the release cycles. ⚠️

@vytick vytick added blocked Blocked by external force. Third party inputs required. message-system Updates in secure message system config solana labels Dec 2, 2024
@vytick vytick mentioned this pull request Dec 2, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 20
  • More info

Learn more about 𝝠 Expo Github Action

@vytick vytick force-pushed the chore/message-system/disable-mobile-solana branch from d1ca884 to 1c5f38c Compare December 4, 2024 13:25
Lemonexe
Lemonexe reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll approve when the message system is deployed to develop 🙂

@vytick vytick changed the title chore(mesage-system): disable solana on mobile via messages ⚠️ Do not merge to develop! Mobile enable solana on mobile via messages Dec 10, 2024
@vytick vytick changed the title ⚠️ Do not merge to develop! Mobile enable solana on mobile via messages ⚠️ Do not merge nor release! Mobile enable solana on mobile via messages Dec 10, 2024
@vytick vytick changed the title ⚠️ Do not merge nor release! Mobile enable solana on mobile via messages Do not merge nor release! Mobile enable solana on mobile via messages Dec 10, 2024
@vytick vytick force-pushed the chore/message-system/disable-mobile-solana branch from 1c5f38c to 6dd4ca8 Compare December 10, 2024 19:51
Lemonexe
Lemonexe approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on localhost

@vytick
Copy link
Contributor Author

vytick commented Jan 13, 2025

this is not going to be used ass the functionality was already removed and the release will happen normally

@vytick vytick closed this Jan 13, 2025
@vytick vytick deleted the chore/message-system/disable-mobile-solana branch January 13, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemonexe Lemonexe Lemonexe approved these changes

@MiroslavProchazka MiroslavProchazka Awaiting requested review from MiroslavProchazka

@tomasklim tomasklim Awaiting requested review from tomasklim tomasklim will be requested when the pull request is marked ready for review tomasklim is a code owner

@matejkriz matejkriz Awaiting requested review from matejkriz matejkriz will be requested when the pull request is marked ready for review matejkriz is a code owner

Assignees
No one assigned
Labels
blocked Blocked by external force. Third party inputs required. message-system Updates in secure message system config solana
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vytick @Lemonexe