Non-blockbook account fetch optimisations #15691
Merged
+279
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
tomasklim
force-pushed
the
feat/crypto-refresh
branch
2 times, most recently
from
28d3ae5
to
45ed4d6
Compare
tomasklim
commented
Dec 3, 2024
tomasklim
commented
Dec 3, 2024
| export const useWindowVisibility = () => { | ||
| const dispatch = useDispatch(); | ||
|
|
||
| const onWindowVisibilityChange = () => { |
There was a problem hiding this comment.
it would be possible to extend this by also having state from electron layer. There is one more state only for macOS. You can also detect when app is cover by another app, but that would make it more complicated for now. Let's tested at least using just Page visibility api from renderer layer
tomasklim
commented
Dec 3, 2024
| const isLessThanDefaultSyncInterval = | ||
| Date.now() - updatedAt < DEFAULT_ACCOUNT_SYNC_INTERVAL; | ||
|
|
||
| if (!isLessThanDefaultSyncInterval) { |
There was a problem hiding this comment.
This is little bit stupid but 1 minute is okay for now, it would be great to have specific refresh time limit for specific chains
tomasklim
force-pushed
the
feat/crypto-refresh
branch
3 times, most recently
from
feabb6d
to
21cf04d
Compare
tomasklim
force-pushed
the
feat/crypto-refresh
branch
from
21cf04d
to
34dc631
Compare
tomasklim
force-pushed
the
feat/crypto-refresh
branch
from
1cb33da
to
b756d16
Compare
tomasklim
force-pushed
the
feat/crypto-refresh
branch
from
4add47d
to
2f47d63
Compare
tomasklim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
solanaX.trezor.iotosolX.trezor.ioso that we can cut old suite versions if neededTODO: refresh buttonmaybe will be done in some future PRs@trezor/qa please test that Cardano and Solana accounts are updated every 5 minutes and that they are updated when you enter them (if they are older than 1 minute). You can check networks tab and just filter
sol, for cardano you have to check websockets