Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tor external process - Allows Trezor Suite use Tor from Tails OS #15642
base: develop
Are you sure you want to change the base?
Tor external process - Allows Trezor Suite use Tor from Tails OS #15642
Changes from 12 commits
d8151a2
2844d98
4490ad6
82be1c1
febf788
8e2cbed
f1864ec
1f0680b
dc55456
e355695
d466407
02eaaa5
72259fa
24fd876
1d3da5a
3f2455b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better, in my opinion. Just two things:
timeout
is a limit for one action attempt after which it throws instead, whilegap
is a delay between two consecutive attempts. It's perfectly fine to have both defined, I just want to make sure that it's what you want.abortController
check inside an action and aborting it fromattemptFailureHandler
, as thegetIsStopped
check could be done in the action itself, which makesattemptFailureHandler
redundant.. If you're not against, I can try to propose an adjustment after the review.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood the difference between
timeout
andgap
, and think in this case both are necessary.Regarding
abortController
if you want to propose and adjustment, it is welcome :)