Custom backends form fix #15629
Merged
Custom backends form fix #15629
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lemonexe
approved these changes
Nov 28, 2024
| @@ -107,6 +107,7 @@ export const CustomBackends = ({ network, onCancel }: CustomBackendsProps) => { | |||
| const { defaultUrls, isLoading } = useDefaultUrls(coin); | |||
| const editable = type !== 'default'; | |||
| const { ref: inputRef, ...inputField } = register(name, { validate }); | |||
| const isSubmitButtonDisabled = type !== 'default' && !!error; | |||
There was a problem hiding this comment.
Nit: could use editable for consistency, because editable is also used for conditions to display the inputs below.
Suggested change
| const isSubmitButtonDisabled = type !== 'default' && !!error; | |
| const isSubmitButtonDisabled = editable && !!error; |
komret
force-pushed
the
fix/custom-backends-submit
branch
from
5de7878 to
066e5f3
Compare
peter-sanderson
approved these changes
Nov 28, 2024
komret
force-pushed
the
fix/custom-backends-submit
branch
from
066e5f3 to
c239ee0
Compare
|
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an obscure bug when form button was disabled for no reason.
Related Issue
Resolve
Screenshots:
before:
Screen.Recording.2024-11-28.at.15.03.39.mov
after:
Screen.Recording.2024-11-28.at.15.01.55.mov