fix(suite): align promo buttons to the right #15591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroslavProchazka
force-pushed
the
fix/button-pos
branch
from
a888559 to
72a2df4
Compare
MiroslavProchazka
force-pushed
the
fix/button-pos
branch
2 times, most recently
from
0a0c8f4 to
8bde401
Compare
tomasklim
reviewed
Nov 27, 2024
jvaclavik
reviewed
Nov 27, 2024
| type="play-store" | ||
| analyticsPayload="android" | ||
| shownQRState={shownQRState} | ||
| <Flex alignItems="center" justifyContent="space-between" width="100%"> |
There was a problem hiding this comment.
Please use Row instead of Flex
MiroslavProchazka
force-pushed
the
fix/button-pos
branch
2 times, most recently
from
52505e7 to
1a11428
Compare
jvaclavik
reviewed
Nov 28, 2024
| type="play-store" | ||
| analyticsPayload="android" | ||
| shownQRState={shownQRState} | ||
| <Row alignItems="center" justifyContent="space-between" width="100%"> |
There was a problem hiding this comment.
you don't have to specify alignItems="center", because it's default value for Row
|
|
||
| ${variables.SCREEN_QUERY.MOBILE} { | ||
| flex-direction: column; | ||
| gap: 0; | ||
| gap: ${spacingsPx.sm}; |
There was a problem hiding this comment.
what about define this in Row?
MiroslavProchazka
force-pushed
the
fix/button-pos
branch
4 times, most recently
from
8a19236 to
aef9e7c
Compare
jvaclavik
reviewed
Nov 29, 2024
| </BadgeContainer> | ||
|
|
||
| <Row> | ||
| <BadgeContainer> |
There was a problem hiding this comment.
Does it work without using BadgeContainer?
(Row and BadgeContainer are defacto duplicity here)
There was a problem hiding this comment.
I will try
MiroslavProchazka
force-pushed
the
fix/button-pos
branch
2 times, most recently
from
2b81646 to
76d3529
Compare
MiroslavProchazka
force-pushed
the
fix/button-pos
branch
from
76d3529 to
edc4e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15575
Before
After
