Mobile: sending Solana #15533
Mobile: sending Solana #15533
Conversation
|
🚀 Expo preview is ready!
|
trezor-ci
force-pushed
the
feat/native/send-solana
branch
from
1edfd80 to
13b6882
Compare
vytick
added
connect
vytick
requested review from
a team,
mroz22,
szymonlesisz,
martykan and
marekrjpolak
as code owners
| minFee: -1, // unused | ||
| maxFee: -1, // unused | ||
| minFee: 25000, | ||
| maxFee: 1000000000, |
There was a problem hiding this comment.
how come that suite didn't need this? 🤔
There was a problem hiding this comment.
There is probably no validation on this. And the fees are determined automatically by fetching the on chain data
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
If I get to the state of timeouted transaction once, I am unable the send any other SOL transaction again. It always resolves in the timeout error. Only that helps is restart of the app. There is probably something rotting in the redux state.
Zaznam.obrazovky.2024-11-25.v.12.39.36.mov
vytick
force-pushed
the
feat/native/send-solana
branch
2 times, most recently
from
853cba5 to
195e5c2
Compare
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| // Subscribe to blocks for Solana, since they are not fetched globally | ||
| // this is needed for correct Solana fee estimation | ||
| if (account && account.networkType === 'solana') { | ||
| TrezorConnect.blockchainSubscribe({ |
There was a problem hiding this comment.
nit: maybe create variable for that params and use in both calls?
There was a problem hiding this comment.
This is a copy of what @martykan used for desktop.
There was a problem hiding this comment.
That doesn't mean it coudn't be improved a bit :D
vytick
force-pushed
the
feat/native/send-solana
branch
from
076fb5a to
84bc3a2
Compare
vytick
force-pushed
the
feat/native/send-solana
branch
from
84bc3a2 to
010a539
Compare
Enables sending Solana and tokens including basic error handling for failed send. No custom fees are allowed (same as desktop).
Related Issue
Resolve #15497
Screenshots:
happy path:
happy_path.mp4
unhappy path:
unhappy_path.mp4